Report Bugs in the Latest Version of Essentials

94lolface

Rookie
Member
Joined
Jul 10, 2017
Posts
4
Likes
7
#42
I'm currently trying to get Stuff Cheeks to work. And it does, but with a catch.
The mon doesn't get the berry's effect when at full HP.

At first I thought the mistake might be on my end, so I tried doing something similar with something that already came with the game: Bug Bite.
Instead of trying to Stuff Cheek my Salac Berry, I tricked it to the opponent instead and used Bug Bite afterwards.

Just like with Stuff Cheeks, Bug Bite works as intended. It steals the opponent's berry and uses it on itself, except it does not actually give the berry's effect while at Full HP, in this case boosting Speed by one stage.

Both, Bug Bite and my own Stuff Cheeks script work as intended, but only when the user took at like one HP of damage.

I figured it has something to do with how pbHeldItemTriggerCheck is defined, so I checked there. Through that I figured that it has something to do with pbItemHPHealCheck instead maybe?
The problem seems to be that the game thinks that for example the Salac Berry has healing properties when in reality it doesn't.

edit: okay so Salac Berry & it's cousins are actually defined as healing items, so they use the check for those as well, thus not working when a mon with full HP uses Bug Bite on a mon with such a berry.
 
Last edited:

Scyl

Ironically Unironic Edgelord Extraordinaire
Member
Joined
Apr 4, 2018
Posts
39
Likes
18
#43
Tiles with the "StillWater" Terrain Tag don't show the reflections of events like they do with the player.
 

boonzeet

Developer of Pokemon: Secrets of the Ages
Member
Joined
Mar 13, 2019
Posts
48
Likes
47
#44
Tiles with the "StillWater" Terrain Tag don't show the reflections of events like they do with the player.
Adding "Reflection" to the name should allow the event to show its reflection. As all reflections are constantly rendered, this is likely for performance.
 

boonzeet

Developer of Pokemon: Secrets of the Ages
Member
Joined
Mar 13, 2019
Posts
48
Likes
47
#45
$MapFactory.isPassable? fails when checking if the square the player is currently on is passable.

The offending block of code appears to be this:
Code:
if thisEvent.is_a?(Game_Player)
  if thisEvent.x == x and thisEvent.y == y
    return false if !thisEvent.through && thisEvent.character_name!=""
  end
end
As the code already earlier checks each against each events location if the input character is $game_player, this code can be rewritten to:
Code:
if !thisEvent.is_a?(Game_Player)
  if thisEvent.x == $game_player.x and thisEvent.y == $game_player.y
    return false if !thisEvent.through && thisEvent.character_name!=""
  end
end
Which may have been the intended outcome, as this will return false for the tile the player is on for events that are NOT the player.
 

NettoHikari

Trainer
Member
Joined
Jan 4, 2019
Posts
67
Likes
27
#46
Ruby:
  def pbHasMoveType?(type)
    type = getConst(PBTypes,type)
    return false if !type || type<0
    eachMove { |m| return true if m.type==type }
    return false
  end

  def pbHasMoveFunction?(*arg)
    return false if !code
    eachMove do |m|
      arg.each { |code| return true if m.function==code }
    end
    return false
  end
Both of these functions in PokeBattle_Battler refer to local variables that don't exist in the functions.
 

NettoHikari

Trainer
Member
Joined
Jan 4, 2019
Posts
67
Likes
27
#47
The "Give" option in the Item Storage screen has a bug where if you give an item to a Pokemon, it also deletes that item from your bag.

Example: I have 1 Potion in my Item Storage, and 1 in my Bag. I go to the Item Storage screen, click on the "Give" option for the Potion, and give it to the Noivern in my party. My Noivern now has a Potion, and my Item Storage is empty, but my bag is now also empty, so it deleted the Potion both from Item Storage and the Bag.
 

Scyl

Ironically Unironic Edgelord Extraordinaire
Member
Joined
Apr 4, 2018
Posts
39
Likes
18
#48
Adding "Reflection" to the name should allow the event to show its reflection. As all reflections are constantly rendered, this is likely for performance.
Ah, thanks.
 
OP
OP
Maruno

Maruno

Pokémon Essentials dev
Essentials Developer
Joined
Apr 5, 2017
Posts
335
Likes
241
#50
Ruby:
  def pbHasMoveType?(type)
    type = getConst(PBTypes,type)
    return false if !type || type<0
    eachMove { |m| return true if m.type==type }
    return false
  end

  def pbHasMoveFunction?(*arg)
    return false if !code
    eachMove do |m|
      arg.each { |code| return true if m.function==code }
    end
    return false
  end
Both of these functions in PokeBattle_Battler refer to local variables that don't exist in the functions.
I see the error in the second method, but the first method works just fine. What do you see in it?

Type Gems don't work.
I can't recreate this. Indeed, I successfully triggered an Electric Gem when using Electro Ball, and all the Gems work the same way. I'll assume your problem is caused by something you've done, as you're clearly not using an unmodified copy of Essentials v18.
 

Scyl

Ironically Unironic Edgelord Extraordinaire
Member
Joined
Apr 4, 2018
Posts
39
Likes
18
#52
I see the error in the second method, but the first method works just fine. What do you see in it?


I can't recreate this. Indeed, I successfully triggered an Electric Gem when using Electro Ball, and all the Gems work the same way. I'll assume your problem is caused by something you've done, as you're clearly not using an unmodified copy of Essentials v18.
This is in a fresh, clean and unmodified version of V18, obtained from the link you posted in: https://reliccastle.com/essentials/#post-18391.

 

Scyl

Ironically Unironic Edgelord Extraordinaire
Member
Joined
Apr 4, 2018
Posts
39
Likes
18
#53
Also, Dragon Tail is bugged, even if you have a Pokémon to send out; it leads to an endless loop of Dragon Tail hitting you until it either misses or you lose.

 

NettoHikari

Trainer
Member
Joined
Jan 4, 2019
Posts
67
Likes
27
#54
I'm using the decompiled scripts from GitHub and I can't seem to open the Debug Console, both from the menu and using the command "Console::setup_console", but it worked fine for me when my scripts were in the normal compiled form (in Scripts.rxdata).
 

DJ323

Rookie
Member
Joined
Sep 20, 2020
Posts
1
Likes
0
#55
I'm a little new here so sorry if this is a bother but I think I've found a few bugs. Though I found them due to my own script editing, I extracted a brand new unmodified v18 2020-09-02 version of Essentials to test these bugs and they exist there too.

1- Metal burst doesn't work. If you are hit, instead of returning the damage an error message pops up (shown below). If you click okay it will loop until the pp runs out.



2- Powder doesn't work. If you set it up to explode (get hit by a fire type move) it will display an error message (shown below). If you click okay it will loop until the opponent's fire type move runs out. (Note: it only occurs when powder causes the explosion). I think the "RAINDANCE" and "HEAVYRAIN" need to be changed to "Rain" and "HeavyRain" respectively starting at line 320 in Battler_UseMove. Also it doesn't have priority for some reason (even though in the PBS files it seems to) and I don't know why this happens.



3- I don't think STAB is working, I did a few damage calculations with and without STAB, with STAB it should have KO'd and without it should have done around 60% but both did 60%.
4- I don't think weather boosts are working. For example fire type moves in sunny day should do more damage than without sunny day but currently they do the same amount and water type moves should do less damage in the sunlight but currently they do the same amount in and out of the sun.

Both 3 and 4 have to do with "multipliers[FINAL_DMG_MULT]" in Move_Usage_Calculations so there could be an issue with storing the values or calculating the final value.

Hopefully this was helpful. If I find any other bugs while going through the scripts I'll post them (after testing them on an unedited copy).
 
Joined
Jan 4, 2019
Posts
67
Likes
27
#56
Ruby:
---------------------------
Pokemon Essentials
---------------------------
[Pokémon Essentials version 18]

Exception: NoMethodError

Message: undefined method `[]' for nil:NilClass



Backtrace:

PScreen_PokedexMain:328:in `pbGetDexList'

PScreen_PokedexMain:325:in `each'

PScreen_PokedexMain:325:in `pbGetDexList'

PScreen_PokedexMain:345:in `pbRefreshDexList'

PScreen_PokedexMain:260:in `pbStartScene'

PScreen_PokedexMain:1187:in `pbStartScreen'

PScreen_PauseMenu:151:in `pbStartPokemonMenu'

PScreen_PauseMenu:148:in `pbFadeOutIn'

PScreen_PauseMenu:153:in `pbStartPokemonMenu'

PScreen_PauseMenu:144:in `loop'
---------------------------
OK  
---------------------------
Hey, so this happens when I try to open my Pokedex. I haven't modified the files. so I'm not sure why this is happening. Can anyone help out? thaaaaaanks
Delete your current save and try again (or rename your project in the editor).
 
Top